-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L4T 35.4.1 and uefi signing #19
Conversation
The majority of this commit was provided by Matt. It includes: - Adding tegra234 to the supported soc types. - Updated required scripts needed from L4T 35.x tooling to be copied to the temporary workdir. Also, support copying required scripts from directories (pyfdt). Signed-off-by: Matt Madison <matt@madison.systems> Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
56c00e8
to
c003eba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the names of the new endpoints to be tegra-uefisign
and tegra-ueficapsulesign
, or something like that to indicate that they're not for other platforms? In the short run, that's probably easier than tracking down the prerequisites and updating the logic to make them generic for other platforms.
Otherwise, overall I think this looks OK. I'll take a closer look at it when I have more time.
Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
- Pre-kirkstone the sdram config had an assumed naming convention for the sdram configuration. Kirkstone and above will pass the sdram configuration via the MANIFEST supplied in the contents of the signing request. Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
that will allow larger payload sizes to be signed. Sanic's default maximum request size is 100MB. Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
c003eba
to
37af994
Compare
- Match naming per feedback in this PR: madisongh/digsigserver#19
Changed the endpoints to BTW, I'll soon have a separate PR for some markdown that documents these endpoints in the style of your other signers. |
I went ahead and just added the extra commit to add new markdown for the new signers. |
Signed-off-by: Chad McQuillen <chad.mcquillen@lexmark.com>
1ea5f53
to
2670db2
Compare
Thanks for all the work on this, @Lexmark-chad ! |
Ready for review. I've tested Xavier NX (dunfell and kirkstone) and Orin NX (kirkstone).