Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly parse datetime values when attributes are set from json value #155

Merged
merged 7 commits into from
Sep 23, 2022
Merged

Properly parse datetime values when attributes are set from json value #155

merged 7 commits into from
Sep 23, 2022

Conversation

haffla
Copy link
Contributor

@haffla haffla commented Sep 18, 2022 •
edited
Loading

Fixes #153

@haffla
Copy link
Contributor Author

haffla commented Sep 18, 2022

@caiohsramos hello! I think we have forgotten something in #137. We only fixed how time values are written to the database but not how they are read (parsed) from the database. I believe this should fix this. Would you mind and give this a review?

@haffla haffla added the bug label Sep 18, 2022
@haffla haffla merged commit 5bf0690 into master Sep 23, 2022
@haffla haffla deleted the bugfix/deserialization-of-datetime branch September 23, 2022 07:10
@jrochkind jrochkind mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiohsramos caiohsramos caiohsramos approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datetime doesn't properly preserve zone
2 participants
@haffla @caiohsramos