Preserve upstream anthropic errors in a wrapper #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tblyler
reviewed
Nov 21, 2024
| @@ -22,7 +23,9 @@ func (c *Client) doRequest(request *http.Request) (*http.Response, error) { | |||
| } | |||
|
|
|||
| if response.StatusCode != http.StatusOK { | |||
| err = anthropic.MapHTTPStatusCodeToError(response.StatusCode) | |||
| defer response.Body.Close() | |||
| body, _ := io.ReadAll(response.Body) | |||
There was a problem hiding this comment.
Did you want to JSON decode into this? https://docs.anthropic.com/en/api/errors
There was a problem hiding this comment.
While the native Anthropic client will return errors in a JSON format, the bedrock client does not. Instead, we get errors that look like:
Bedrock Runtime: InvokeModel, https response error StatusCode: 403, RequestID: ----, api error ExpiredTokenException: The security token included in the request is expired
Given this, I left errResponse as a string to handle all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@madebywelch
I have a need to consume the raw errors we're getting from Anthropic/Bedrock.
Instead of suppressing the errors and returning the predefined strings, I have created a wrapper class that implements the error interface, but keeps the predefined strings in place to support backwards compatibility. Checking the error string or utilizing
errors.Iswill remain the same.However, by utilizing this wrapper, it enables us to use
errors.Asand extract the upstream error from Anthropic/Bedrock.Let me know your thoughts.