Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcaca: remove need for compiler blacklist #12828

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

evanmiller
Copy link
Contributor

Description

This allows building with older Clang, fixes the build with GCC, and generally simplifies the existing workarounds to cacalabs/libcaca#59

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.4.11 8S165 Power Macintosh
Component versions: DevToolsCore-798.0; DevToolsSupport-794.0

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@reneeotten
Copy link
Contributor

thanks @evanmiller can you perhaps also traige which of the Trac tickets are still relevant or could be closed?

@evanmiller
Copy link
Contributor Author

evanmiller commented Nov 6, 2021

@mascguy
Copy link
Member

mascguy commented Nov 7, 2021

Given that I'm the one that recently added the compiler blacklisting, it seems only fair that I merge this! LOL

@mascguy mascguy merged commit d8cc25e into macports:master Nov 7, 2021
@mascguy
Copy link
Member

mascguy commented Nov 7, 2021

Close:

42124 - libcaca should not depend on port:imlib2

The Mavericks-related ticket (46939) was fixed by my blacklist-related commit a few days ago, so I closed that one too.

However, can you confirm that the imlib2-related ticket should be closed? It looks like there's still a dependency on that port...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants