Skip to content

Commit

Permalink
Remove call to metrics.WithResourceAttributesAsTags()
Browse files Browse the repository at this point in the history
Removes call to `metrics.WithResourceAttributesAsTags()` which is a no-op. This option is picked up here: https://github.com/DataDog/datadog-agent/blob/main/comp/otelcol/otlp/internal/serializerexporter/factory.go#L60.

This option will been removed from `pkg/otlp/metrics` in this PR: DataDog/opentelemetry-mapping-go#219

This was flagged here: open-telemetry#29702
  • Loading branch information
mackjmr committed Dec 12, 2023
1 parent 5423402 commit 121235e
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions exporter/datadogexporter/metrics_exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ func translatorFromConfig(logger *zap.Logger, cfg *Config, sourceProvider source
options = append(options, otlpmetrics.WithQuantiles())
}

if cfg.Metrics.ExporterConfig.ResourceAttributesAsTags {
options = append(options, otlpmetrics.WithResourceAttributesAsTags())
}

if cfg.Metrics.ExporterConfig.InstrumentationScopeMetadataAsTags {
options = append(options, otlpmetrics.WithInstrumentationScopeMetadataAsTags())
}
Expand Down

0 comments on commit 121235e

Please sign in to comment.