Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper WASM support feature flags and tests #33

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

dingxiangfei2009
Copy link

@dingxiangfei2009 dingxiangfei2009 commented Sep 28, 2021

This PR will supersede #32 if preferred.

This PR proposes the following changes:

  1. Enable proper WASM flags in the dependencies
  2. Remove parking_lot feature flag from once_cell, as suggested by its author matklad. In summary, recent once_cell has adapted to better work with std mutexes. See the discussion here
  3. Adapt the tests to run with wasm-pack by conditionally using wasm-bindgen-test

Copy link

@wigy-opensource-developer wigy-opensource-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loved the declarative macro for switching between different test proc_macros. Was there a reason you did not use them for a few files?

@maciejhirsz
Copy link
Owner

Cheers! Would be great to expand CI to also run the tests on Wasm, but that can come later.

@maciejhirsz maciejhirsz merged commit fa94d97 into maciejhirsz:master Sep 29, 2021
@maciejhirsz
Copy link
Owner

Published in 0.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants