Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-build] Use Zeroizing instead of derive for mnemonic #29

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

LLFourn
Copy link

@LLFourn LLFourn commented Sep 21, 2021

The language doesn't need to be zeroized. This more concisely covers what is important to zeroize and fixes the build.

I am not sure which change in zeroize_derive was the breaking one.

More concisely covers what is important to zeroize and fixes the build.
@notmandatory
Copy link

notmandatory commented Sep 21, 2021

ACK e103ab8, tested with bitcoindevkit project and it fixes an issue we had with MSRV support and zeroize.
Oops, nevermind still broken building with rustc 1.46.0

bitcoindevkit/bdk#399 (comment)

@maciejhirsz
Copy link
Owner

Build failing will be fixed with #31.

@maciejhirsz maciejhirsz merged commit 2bafd5d into maciejhirsz:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants