Ember 4 Upgrade #515
Ember 4 Upgrade #515
Conversation
elwayman02
commented
Mar 23, 2023
•
elwayman02
commented
- Bump to latest github action versions
- Add Ember 4.4 scenario, drop scenarios below 3.28
- Switch from npm-run-all to concurrently
- Add ember-source peerDep
- Add node 18 support
- ember-modifier v3 (v4 is available but may require additional migration work)
- Added ember-sinon-qunit to make sinon play nice with ember-auto-import
- Bump volta to latest node/yarn minor/patch versions
- Convert assert.equal to assert.strictEqual or assert.deepEqual
- Autofix additional lint errors and disable 2 rules with weird errors
- Update caniuselist db
| @@ -2,4 +2,8 @@ | |||
|
|
|||
| module.exports = { | |||
| extends: 'recommended', | |||
| rules: { | |||
| 'no-whitespace-for-layout': false, | |||
| 'require-input-label': false, | |||
There was a problem hiding this comment.
Turned off these two new rules because they had a couple violations that didn't make sense to fix:
- A test rendered an input without a label
- 2 of the docs templates threw "extra whitespace" errors but it seemed like a bug. I couldn't fix it.
There was a problem hiding this comment.
Only 3 violations exist between the two of them, so they could be reenabled pretty easily if someone wants to attempt a fix.
|
Actually, I believe ember-qunit and some other dependencies are finally forcing a drop of support for <3.28. I'll go ahead and remove these scenarios as it was going to be a major version bump anyway, and it's probably about time to drop support for Ember versions that have long been EOL'd. If you feel strongly that those scenarios need to be maintained still, I'm open to you pushing the proper changes to this branch to keep them working. 👍 |
|
We can probably drop node 10/12 support as well as part of this major release. What do you think? |
@elwayman02 we should do it in a separate PR, right? |
|
Yea, it doesn't have to be done in this PR as long as the CI builds pass
once someone enables them.
…On Mon, Mar 27, 2023 at 7:37 AM Sergey Astapov ***@***.***> wrote:
We can probably drop node 10/12 support as well as part of this major
release. What do you think?
@elwayman02 <https://github.com/elwayman02> we should do it in a separate
PR, right?
—
Reply to this email directly, view it on GitHub
<#515 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKDTKU3S5NSM4WUWWF4LDTW6GQZDANCNFSM6AAAAAAWEQGQCE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@machty are you able to take a look at this? It would be great to get tests actively running against an explicit 4.x LTS scenario soon. :) |
* Bump to last github action versions * Add Ember 4.4 scenario * Switch from npm-run-all to concurrently * Add ember-source peerDep (back to 3.8 to support existing scenarios) * Add node 18 support * ember-modifier v3 (v4 is available but may require additional migration work) * Added ember-sinon-qunit to make sinon play nice with ember-auto-import * Bump volta to latest node/yarn minor/patch versions
Convert assert.equal to assert.deepEqual for objects
Disable 2 template lint rules that were causing weird behavior
* Also no need to specify e-a-i/webpack versions for latest Ember scenarios since they're always included now.
