test: reads('task.last.value') tracked prop interop
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`^7.1.3` -> `^10.0.1` Also adds `sass` as the new default sass implementation. This allows running the dummy app with Node 12.
buschtoens
commented
Jun 3, 2019
|
|
||
| assert.strictEqual(this.element.textContent.trim(), 'reads: ; direct: ;'); | ||
|
|
||
| this.subject.otherTask.perform(); // toggle this line |
There was a problem hiding this comment.
The error only occurs, if this line is executed. If you comment it out, the the test will pass.
buschtoens
commented
Jun 3, 2019
| return 1337; | ||
| }), | ||
|
|
||
| lastValue: reads('task.last.value') |
There was a problem hiding this comment.
If I substitute last with lastSuccessful instead, it also works.
`^6.8.2` -> `^7.7.3` This enables the usage of decorators. Also removes the deprecated `babel.blacklist` config. This is now handled via the browser `targets.js`.
buschtoens
force-pushed
the
bug/tracked-properties
branch
from
295d66d
to
89b92dd
Compare
|
Fixed via emberjs/ember.js#18073! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading our app to Ember Octane, I found that there is an issue with the interoperability of
task.last.valueand thereadscomputed property when tracked properties (EMBER_METAL_TRACKED_PROPERTIES) are enabled.I don't yet understand the specific internals and haven't dug deeper, but I was able to conjure up a reliable minimal reproduction.
You can run the test case with:
ember try:one ember-canary-tracked-properties --skip-cleanup --- ember s -e testThe test module is named
Integration | reads('task.last.value').This PR includes #299, because I couldn't get ember-cli to run otherwise.