Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: statefulset support #16

Merged
merged 1 commit into from
Feb 11, 2024
Merged

feat: statefulset support #16

merged 1 commit into from
Feb 11, 2024

Conversation

maxime1907
Copy link
Contributor

No description provided.

@maxime1907
Copy link
Contributor Author

Hello @machine424 😄

machine424
machine424 reviewed Feb 6, 2024
View reviewed changes
Copy link
Owner

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Maxime :) thanks for the PR.

tests/e2e_test.py Outdated Show resolved Hide resolved
@maxime1907
Copy link
Contributor Author

it should be ok now^^

@machine424
Copy link
Owner

You can run the tests locally on a kind if you want:

kube-hpa-scale-to-zero/.github/workflows/test.yaml

Line 38 in 8bddc0d

pytest -vv .

@maxime1907
Copy link
Contributor Author

maxime1907 commented Feb 7, 2024 •
edited
Loading

You can run the tests locally on a kind if you want:

kube-hpa-scale-to-zero/.github/workflows/test.yaml

Line 38 in 8bddc0d

pytest -vv .

its tested and should be ok!

@machine424 machine424 merged commit 67fc3fd into machine424:main Feb 11, 2024
1 check passed
@maxime1907
Copy link
Contributor Author

thanks! could you push the chart and the docker image?

@machine424
Copy link
Owner

v0.4.0 was released ;) Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machine424 machine424 machine424 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxime1907 @machine424