Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added image_tag field to overwrite 'latest' #16

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Conversation

rf152
Copy link

@rf152 rf152 commented Aug 12, 2022

This adds the ability to change the default "latest" tag that is applied to a push, for example to set the tag to "beta" on a main branch push.

@macbre macbre self-requested a review August 12, 2022 09:23
@macbre
Copy link
Owner

macbre commented Aug 12, 2022

@rf152, welcome and thanks for this PR!

I'll double check what's wrong with the CI checks - your changes look fine to me 🙂

@rf152
Copy link
Author

rf152 commented Aug 25, 2022

Did you have any luck with this? I have a project that I would quite like to use it on!

@macbre
Copy link
Owner

macbre commented Aug 26, 2022

I deserve a big facepalm 🤦🏻‍♂️

Screenshot 2022-08-26 at 14 26 28

The CI check does not work as you're trying to push to my ghcr repository from your fork's Actions. Let me just merge your changes and I'll add a CI case for your change later on.

Thanks again for your change, @rf152 !

@macbre macbre merged commit f962a32 into macbre:master Aug 26, 2022
@macbre
Copy link
Owner

macbre commented Aug 26, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants