A little clean up, some fixen, and a few tests. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bryanheinz
commented
May 30, 2022
bryanheinz
commented
- Cleaned up my bad merge on Devices.get_device() and adds some help docs
- Closes the session on deinit that the Connection class now opens
- Resolves issue URL params are not handled cleanly when defined #45 by preserving input parameters instead of overwriting them
- Added setup.cfg and pyproject.toml files for packaging new releases
- Added a few basic tests
- Updates the changelog and gitignore files
- params input is now converted to req_params while preserving any input params
- Added needed package files
rickheil
pushed a commit
that referenced
this pull request
Dec 2, 2022
* resolves the bug in issue #25 by removing id_override, replacing data with params, and adding specific input parameters. * required changes to resolve the bug in issue #25. migrated from updating the url in _get_data to a local _params variable that is updated with the input params var. * added Unreleased section and updated with issue #25 changes. * Fix calls that return a single item. * Return single items without wrapping in list. * added params= to be explicit, and marked a potential bug. * updated CHANGELOG * added docstring * updated CHANGELOG * Resolves Issue 38 (#1) * Resolves issue #38 * Resolves issue #24 - Updated update_device input to accept both name and device_name input (breaking change) - Data is now updated with the inputs - Added validation that data has input - Updated the README with update_device's new inputs * Adding download option to profile * Update CHANGELOG.md * v3.0.7 * adding _get_xml connection * update CHANGELOG * update README * Adding include_awaiting_enrollment option #43 (#44) * Merging dev branch (#46) * Use request params instead of url string in SimpleMDM._get_data() * Fix Devices.delete_device() * Add methods for enabling/disabling remote desktop * Add /devices request rate limiting * Add profile and user listing * Add retry on 5xx errors to GET requests * Updates gitignore and changelog (#47) - Added ignoring egg files - Updated changelog * A little clean up, some fixen, and a few tests. (#48) - Cleaned up my bad merge on Devices.get_device() and adds some help docs - Closes the session on deinit that the Connection class now opens - Resolves issue #45 by preserving input parameters instead of overwriting them - Added setup.cfg and pyproject.toml files for packaging new releases - Added a few basic tests - Updates the changelog and gitignore files * Add script support * Add error handling for update_script * Fix handling of req_params for pagination * Update CHANGELOG.md * Fix handling of req_params for pagination * Update CHANGELOG.md * Add Sample Projects Adding some samples projects for issue #28 * Use monotonic time for rate limit and fix sleep time calc * Update CHANGELOG.md Co-authored-by: Steve <steve.kueng@gmail.com> Co-authored-by: Bryan Heinz <git@bryanheinz.com> Co-authored-by: Jon Crain <joncrain@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.