Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of Japanese text #637

Closed
enpipi opened this issue Aug 13, 2024 · 5 comments
Closed

Optimization of Japanese text #637

enpipi opened this issue Aug 13, 2024 · 5 comments

Comments

@enpipi
Copy link
Contributor

enpipi commented Aug 13, 2024 •
edited
Loading

I am Japanese. I feel uncomfortable with the Japanese translation.
I will propose a Japanese sentence. It may be possible to make it the target of updateElements.

  • RequiredDate
    • As-Is: 必要な日付
    • To-Be: 更新期限
      • This means "deadline".
  • Actively Exploited CVEs
    • As-Is: Actively Exploited CVEs
    • To-Be: 悪用されたCVE

If I can get a list of the target characters, I will translate them all.
I will also ask other people I know to help.
@erikng
Copy link
Member

erikng commented Aug 13, 2024

https://github.com/macadmins/nudge/blob/e9a042b864a0435858b7971d0b7c90ee46375ca2/Localizable.xcstrings

All of the text is here. Each value has its corresponding "ja" key but honestly it's much simpler to do this within Xcode than the file directly.

enpipi added a commit to enpipi/nudge that referenced this issue Aug 13, 2024
@enpipi
update japanase text
f768985 
link macadmins#637
It is possible that some of the display locations have not been accurately identified, so the content will need to be checked again.

- Change Device from "デバイス" to "端末"
@enpipi
Copy link
Contributor Author

enpipi commented Aug 13, 2024

Thank you. I'm creating a pull request.

@erikng
Copy link
Member

erikng commented Aug 14, 2024

Saw you committed something in your own repo but no PR.

@erikng
Copy link
Member

erikng commented Aug 16, 2024

I added your changes here

647f81a

@erikng erikng closed this as completed Aug 16, 2024
@erikng erikng mentioned this issue Aug 16, 2024
Merged
@enpipi enpipi mentioned this issue Aug 16, 2024
Merged
@enpipi
Copy link
Contributor Author

enpipi commented Aug 16, 2024

@erikng
I apologize for any inconvenience caused by my English studies.
I made some corrections to the translation.
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikng @enpipi