Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Styles Fix - commit to this repo #311

Merged
merged 15 commits into from
Jan 17, 2021
Merged

Conversation

mac-s-g
Copy link
Owner

@mac-s-g mac-s-g commented Jan 16, 2021

No description provided.

@mac-s-g
Copy link
Owner Author

mac-s-g commented Jan 16, 2021

i wasn't sure how to handle the commits to a forked repo from #298.

so i created this duplicate merge request. I'm reviewing what's up with Travis. Once I sort that out, I'll merge and close both mr's.

this is meant to fix #121.

thanks for the great work @thomasjm !

@mac-s-g
Copy link
Owner Author

mac-s-g commented Jan 16, 2021

looks like the coverage report started failing. probably due to the major update to nyc.

i'm working on resolving now.

@mac-s-g
Copy link
Owner Author

mac-s-g commented Jan 17, 2021

lint errors are now resolved. i also upgraded babel.

however, coveralls integration is failing. working on resolving the error now.

react-json-view@1.19.1 test:coverage /home/mac/dev/git/personal/react-json-view
> NODE_ENV=test nyc report --reporter=text-lcov | coveralls

[error] "2021-01-17T01:50:27.864Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2021-01-17T01:50:27.866Z"  'input: ' ''
[error] "2021-01-17T01:50:27.866Z"  'error from convertLcovToCoveralls'

/home/mac/dev/git/personal/react-json-view/node_modules/coveralls/bin/coveralls.js:19
      throw err;

@mac-s-g
Copy link
Owner Author

mac-s-g commented Jan 17, 2021

woo! everything's passing. gonna merge. i'll follow up with a minor bump as a handful of changes have been deployed recently.

@mac-s-g mac-s-g merged commit e58c4e0 into master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants