This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thank you for creating this framework, it's been a ton of fun to use.
I, and a few others working on a small project together, came across this bug while trying to create some custom fields in the configuration manager page. We were running in to a bug where the
npm
commands in thepreBuildHTML.py
script weren't getting run as intended.We've been using PlatformIO to compile (on both Mac and Linux).
PlatformIO: Core-5.2.3
The versions of python we've been using:
Mac - python:3.8.2
Linux - python:3.7.3
Below is a copy of the commit message to give more detail on the changes. Please let me know if any more information is needed/wanted and thank you for considering this PR.
Why:
While trying to rebuild the HTML for custom attributes, the
preBuildHTML.py script was failing when calls were made to
subprocess.call
. Under the hood thesubprocess.call
functioncalls
Popen
. The following is from the documentation page of thesubprocess library:
https://docs.python.org/3/library/subprocess.html#subprocess.Popen
While the documentation says that passing a sequence of program
arguments should work as intended, building on linux and Mac both
failed when using the sequence and succeeded when using a single
string.
This change addresses the need by:
subprocess.call
in preBuildHTML.py to usesingle string instead of list as the first argument.