Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add custom media session attributes docs to readme #37

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

schallock
Copy link
Contributor

Summary

  • Adds explanation of and examples for custom media session attributes

Testing Plan

  • This is only a docs change, no testing needed

Reference Issue

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@jasonmgeorge jasonmgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No comments

@jasonmgeorge
Copy link

@einsteinx2 do we need to update to address any of these semantic release failures?

@jasonmgeorge jasonmgeorge requested a review from einsteinx2 July 12, 2023 19:22
@einsteinx2
Copy link

@jasonmgeorge So all the semantic stuff is just complaining about branch and PR name rules, which is fine. The unit tests aren't running because for some reason due to needing a token to check out Eric's branch (which doesn't make sense to me since it's public), but since it's a docs only change that also doesn't matter.

@einsteinx2 einsteinx2 changed the title Add custom media session attributes docs to readme docs: Add custom media session attributes docs to readme Jul 12, 2023
Copy link

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@einsteinx2 einsteinx2 merged commit 016f5f1 into mParticle:main Jul 12, 2023
mparticle-automation added a commit that referenced this pull request Aug 4, 2023
## [1.5.1](v1.5.0...v1.5.1) (2023-08-04)

### Documentation

* Add custom media session attributes docs to readme ([#37](#37)) ([016f5f1](016f5f1))

### Updates & Maintenance

* bump android from 1.8.10 to 1.8.22 ([#34](#34)) ([898b05e](898b05e))
* bump android from 1.8.22 to 1.9.0 ([#40](#40)) ([0495303](0495303))
* bump org.jlleitschuh.gradle.ktlint from 11.3.2 to 11.4.0 ([#33](#33)) ([21b2497](21b2497))
* bump org.jlleitschuh.gradle.ktlint from 11.4.0 to 11.4.1 ([#36](#36)) ([3377539](3377539))
* bump org.jlleitschuh.gradle.ktlint from 11.4.1 to 11.4.2 ([#38](#38)) ([1ac3f3a](1ac3f3a))
* bump org.jlleitschuh.gradle.ktlint from 11.4.2 to 11.5.0 ([#39](#39)) ([fdebf1e](fdebf1e))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants