Fixed status checks on protected branches. #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFtZ
force-pushed
the
bug/ci-status-checks
branch
from
87c7aaa
to
63c5d8a
Compare
MoFtZ
force-pushed
the
bug/ci-status-checks
branch
from
63c5d8a
to
2d7de1c
Compare
m4rs-mt
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masteris a protected branch in GitHub, and requiresall-required-checks-doneto pass.As described in this article, when path filtering is used, other CI workflows need their own
all-required-checks-done.Added
all-required-checks-doneto website CI workflow. This is separate from the main CI workflow, so it needs its own.Removed automated PR workflows from main CI ignore list. They will not be updated often, so not worth the trouble of a generic/fallback workflow as suggested in the article above. Otherwise, we would constantly need to update both the main CI workflow and fallback workflows for newly added paths to ignore.