Enabled nullable annotations. #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFtZ
force-pushed
the
feature/nullable
branch
2 times, most recently
from
ede4e6d
to
5b7a68c
Compare
|
Resolved merge conflicts. |
m4rs-mt
reviewed
May 21, 2023
MoFtZ
force-pushed
the
feature/nullable
branch
3 times, most recently
from
ba2164f
to
d6db1f8
Compare
m4rs-mt
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled C# nullable reference types, and updated the codebase with annotations.
Added
AsNotNullmethod to apply the null-forgiving!operator. This makes it easier to find the usages, and will allow us to later apply global changes like assertions.Added
ThrowIfNullmethod to throw an exception when the call should never fail.Added
InitNotNullablemethod for cases when the type should not be nullable, but we need to set it tonullanyway. This normally occurs in the constructor, where we known it will be initialized before use.