Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inlining of blocks with more than two successors. #869

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

m4rs-mt
Copy link
Owner

@m4rs-mt m4rs-mt commented Oct 20, 2022

This PR fixes a problem in the Inliner transformation that blocked the inlining of function calls in blocks with more than two successors.

This PR also fixes #846. After a detailed investigation, we concluded that no further fix is needed for the problem because the IR was already assumed to be in a certain state before the InferAddressSpaces pass is applied to the program.

@m4rs-mt m4rs-mt added the bug label Oct 20, 2022
@m4rs-mt m4rs-mt added this to the v1.3 milestone Oct 20, 2022
@m4rs-mt m4rs-mt force-pushed the fixed_inliner branch 3 times, most recently from d757f1e to d9b8f9c Compare October 20, 2022 15:57
@m4rs-mt m4rs-mt marked this pull request as ready for review October 20, 2022 15:57
@m4rs-mt m4rs-mt merged commit a50137f into master Oct 21, 2022
@m4rs-mt m4rs-mt deleted the fixed_inliner branch October 21, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw exception of illegal memory access with OptimzationLevel.O2
2 participants