Restored CudaMemoryBuffer MemSet and CopyTo semantics from 1.0. #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4rs-mt
force-pushed
the
adapted_cuda_streams
branch
from
7856bf7 to
47e8d4f
Compare
MoFtZ
previously approved these changes
Oct 20, 2022
m4rs-mt
force-pushed
the
adapted_cuda_streams
branch
from
47e8d4f to
c855f4a
Compare
m4rs-mt
force-pushed
the
adapted_cuda_streams
branch
from
c855f4a to
8161f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the semantics of several
CudaMemoryBufferhelper functions that performmemsetandmemcpyoperations. Previously (inv1.0), it was possible to pass anullstream to these functions. To preserve semantics, this PR adds additional checks to the specific accelerator binding functionality used within these functions inv1.1andv1.2.