Do not error out of g{read,write}_with if the offset is equal to slice len #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e len It does not allow reading zero-sized types (like possibly an empty array) from empty slice Co-authored-by: Raito Bezarius <masterancpp@gmail.com>
RaitoBezarius
force-pushed
the
zero-sized-types
branch
from
8a59275 to
d6debac
Compare
m4b
approved these changes
Nov 21, 2023
m4b
pushed a commit
that referenced
this pull request
Dec 31, 2023
…et is equal to slice len (#94) We now allow reading zero-sized types (like possibly an empty array) from empty slice, or the exact end of a byte array, and similarly, one can write a empty string or byte array into the tail end of a byte array (i.e., write nothing to nothing). Co-authored-by: Nickie S <DCNick3@users.noreply.github.com>
|
released in 0.12.0, happy new year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retake of #81.
It does not allow reading zero-sized types (like possibly an empty array) from empty slice
Contains documentation in the
PreadandPwritetrait, test is fixed.