Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors due to incorrect MSRV #90

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Fix CI errors due to incorrect MSRV #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
matrix:
build: [MSRV, stable, nightly, macos, win32, win64]
include:
- build: MSRV # Minimum supported Rust version
- build: MSRV # Minimum supported Rust version, ensure it matches the rust-version in Cargo.toml
os: ubuntu-latest
rust: 1.62.1
rust: 1.63
- build: stable
os: ubuntu-latest
rust: stable
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ license = "MIT"
documentation = "https://docs.rs/scroll"
description = "A suite of powerful, extensible, generic, endian-aware Read/Write traits for byte buffers"
include = ["src/**/*", "Cargo.toml", "LICENSE", "README.md"]
rust-version = "1.63"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh actually i didn't want to bump the msrv here because we don't have an actual requirement in scroll itself (only the dev deps)


[dependencies]
scroll_derive = { version = "0.11", optional = true, path = "scroll_derive" }
Expand Down
Loading