Calculate number of read bytes for sections using file alignment

[tathanhdinh]

Hello all,

The pointer_to_raw_data of each section should be rounded down to a multiple of 512. Moreover, the valid address range of each section should be calculated using also size_of_raw_data and file_alignment, e.g. quine.exe has virtual_size (of its unique section) is zero, but it is a valid PE.

To make the review becomes easier, I split the previous PR (which is closed), into parts.

Many thanks for any comments.

[m4b]

heh; i assumed the update branch button would rebase your commits on top; but it does not... what a pain in the ass

[m4b]

I think this looks good to me, but I don't really have the bandwidth at the moment to fully review this. @philipc @willglynn (or anyone else) do you have any comments here? I'm inclined to just merge since it seems more or less fine.

[philipc]

It is clearer to do: cmp::min(read_size, round_size(size_of_raw_data)) (and same for virtual size).

[tathanhdinh]

@philipc thanks for your comments. It's is indeed clearer with cmp::min

[philipc]

Looks fine, assuming the linked stackoverflow answer is correct (which is not something I can judge, this is all undocumented, in fact it's disallowed by the documentation...). From what I've read, this only applies to PE executables, not COFF objects, so this will need changing if we reuse this code for COFF.

[philipc]

@tathanhdinh Can you rebase this to remove the extra 3 commits?

[tathanhdinh]

@philipc Thanks for the remarks, the rebase has been done.

[philipc]

Thanks for your patience!