[generators] Expose m3cluster env in pod spec #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to reference `${M3CLUSTER_ENVIRONMENT}` in custom
configmaps to reduce boilerplate. Also fixes a bug in container
environment creation that would previously overwrite default environment
variables.
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 75.22% 75.23% +0.01%
==========================================
Files 30 30
Lines 2091 2092 +1
==========================================
+ Hits 1573 1574 +1
Misses 391 391
Partials 127 127Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to reference
${M3CLUSTER_ENVIRONMENT}in customconfigmaps to reduce boilerplate. Also fixes a bug in container
environment creation that would previously overwrite default environment
variables.