New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented some TODOs #89

Closed

tztsai wants to merge 2 commits into m2lines:main from tztsai:impl-todos

tztsai commented Aug 23, 2023

Added a decorator in analysis/analysis.py to allow a function to specify a save_file parameter that saves the plot.
Implement some TODOs in models/base.py.
Added a --device argument in the CMD argument parser to specify the device used for training.


          finish some TODOs

af1ce38

dorchard requested a review from raehik

October 17, 2023 16:14

raehik added the stalled label


          Update base.py

810e39d

Contributor

raehik commented Dec 6, 2023 •

edited

Loading

The --device argument point is added in #97 .

We can rebase after merging #97 and test that it's all OK (analysis changes are relevant to Jupyter notebooks, model is training).

raehik removed their request for review

December 6, 2023 15:19

tztsai closed this by deleting the head repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stalled