Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add url param for disabling audio at begining. #261 #265

Merged
merged 1 commit into from
Mar 27, 2023
Merged

add url param for disabling audio at begining. #261 #265

merged 1 commit into from
Mar 27, 2023

Conversation

urbanekpj
Copy link

see #261
PR add option to disable audio at beggining on client side. stat muted but also don't show muteOverlay, assuming audio will be played on different device. and it will be displayed with cast option.

@m1k1o
Copy link
Owner

m1k1o commented Mar 25, 2023

I'd rename to ?muted=1 or maybe ?volume=<number> where user could choose own volume. Not sure if that would have any usecase, but if ?volume=0 it would simply mean muted, and ?volume=1 is maximum as usual. What do you mean?

Because this does not really disable audio. That would need to be propragated to server-side, so that it never actually sends audio track to the client. This could reduce latency, because video would not need to be synced with audio. That would be a different feature. Or if you wish to imlement this feature, that'd be also great.

@urbanekpj
Copy link
Author

i like volume param.
it is simpler.
i volume=0.0 then audio is not playing and not mutedOverlay is visible.

about use case. i have two devices. one large display(cast=1 audio video, no controls) and second smaller embedded device touch interface( implicit control, no audio). desired configuration is that smaller device will have no audio and no additional controls or overlays. so i need volume=0 on client device not on server. because audio will be played on 'large' display.

ps i didn't set mute = true when volume=0 to not show muted overlay. it will be automatically set when it will bo impossible to play audio automatically.

@m1k1o m1k1o merged commit 98ba32c into m1k1o:master Mar 27, 2023
@urbanekpj urbanekpj deleted the pu/disable_audio branch March 28, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants