Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature to Ignore IP addresses in subdomain scan #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Feature to Ignore IP addresses in subdomain scan #32

wants to merge 1 commit into from

Conversation

samsheff
Copy link
Contributor

@samsheff samsheff commented Jul 4, 2019

I was using CloudFail on a domain with a wildcard dns entry, and it was spitting out false positives with the same IP. So I added a flag which allows you to ignore results that match an ip address (or in list of IP's) to avoid seeing junk results. One or Multiple IP addresses can be added to the -i/--ignore parameter with space as a delimiter.

Usage looks like this: python3 cloudfail.py -t <target> -i <ip1> <ip2>

If you have any questions or additional edits, let me know :) Happy to make changes if needed!

@DatDraggy
Copy link
Contributor

Interesting approach.
My pull request regarding this problem has been open for a year now. Good luck with yours

@samsheff
Copy link
Contributor Author

samsheff commented Jul 4, 2019

@DatDraggy lol I didnt even look before making this. Hopefully one of us gets merged! 👍 My Dockerfile PR did, but that was two years ago, so we'll see)

@DatDraggy
Copy link
Contributor

I think both solutions could be merged. If I already have an IP for sure I don't need to see it again ^^ Useful in some cases imo

@m0rtem
Copy link
Owner

m0rtem commented Jul 8, 2019

@DatDraggy @samsheff Hi guys, apologies for being a ghost the past year, life has taken a very busy turn it seems and I generally don't have much time in-front of a computer that's not in the office...

BUT I will review both of your PR's this week, as I know you have both done good work to CF and since it is open source I do not see the problem with multiple people adding and contributing. All I can say again is sorry, and thank you both for your work to this project. Ill keep you guys in the loop.

@DatDraggy
Copy link
Contributor

Oh no worries. This is just an open source project and people were still able to use our forks.
IRL things are of course more important.

@mathieu-aubin
Copy link

what happenned to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants