Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kim benchmark improvements #5

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Kim benchmark improvements #5

merged 5 commits into from
Nov 27, 2023

Conversation

Disper
Copy link

@Disper Disper commented Nov 27, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • input file name is based on date and time so it will be possible to easily revisit or possibly undo multiple benchmark runs
  • fixes an issue where the output of the script couldn't be piped to kubectl apply because runtimeIDs were not lowercase
  • adds documentation on how to use benchmark.sh

Related issue(s)

This was referenced Nov 27, 2023
Closed
Closed
grego952
grego952 reviewed Nov 27, 2023
View reviewed changes
hack/benchmark/README.md Outdated Show resolved Hide resolved
hack/benchmark/README.md Outdated Show resolved Hide resolved
hack/benchmark/README.md Outdated Show resolved Hide resolved
@Disper @grego952
Apply suggestions from code review
f21e89d 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
m00g3n
m00g3n approved these changes Nov 27, 2023
View reviewed changes
Copy link
Owner

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m00g3n m00g3n merged commit cb932fd into m00g3n:kim-benchmark Nov 27, 2023
2 checks passed
@Disper Disper deleted the kim_benchmark_improvements branch December 15, 2023 11:46
m00g3n pushed a commit that referenced this pull request Jul 2, 2024
@koala7659
fix linter errors #5
ced19f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 left review comments

@m00g3n m00g3n m00g3n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @m00g3n @grego952