Allow the ControllerAs syntax

[samudurand]

It would be really nice if it was possible to add a parameter allowing to set the 'ControllerAs' attribute of the modal. For a classic modal I would do something like :

function openListCreationForm() {
   var modalInstance = $modal.open({
   templateUrl: 'app/home/listCreationForm.tpl.html',
   controller: 'ListCreationModalController',
   controllerAs: 'lcf'
 });

 modalInstance.result.then(function () {
 }, function () {});
 }

for this project you could modify slightly your syntax with a parameter 'lcf' like this :

var dlgs = dialogs.create('app/home/listCreationForm.tpl.html', 'ListCreationModalController','lcf', {}, 'lg');

[m-e-conroy]

I'll add this as a TODO, the service was created back when controllerAs wasn't available.

[samudurand]

👍

[venil7]

desperately need this functionality

[niemyjski]

Can you submit a pull request for this.

[venil7]

#158

[niemyjski]

Change looks good to me. @samudurand can you test and verify it's good. Once I hear back I'll merge it.

[niemyjski]

Merged

[niemyjski]

@m-e-conroy 5.2.11 has been pushed

[m-e-conroy]

Sweet, thanks. Sorry haven't been able to participate much lately.
On Dec 10, 2015 12:07 PM, "Blake Niemyjski" notifications@github.com
wrote:

@m-e-conroy https://github.com/m-e-conroy 5.2.11 has been pushed

—
Reply to this email directly or view it on GitHub
#85 (comment)
.