Skip to content

Commit

Permalink
add defaults again after importing user_module (facebookresearch#3007)
Browse files Browse the repository at this point in the history
Summary:
## What does this PR do?
Default values for the configs imported from `user_dir` was not added properly.

Pull Request resolved: https://github.com/fairinternal/fairseq-py/pull/3007

Reviewed By: alexeib

Differential Revision: D33926315

Pulled By: wnhsu

fbshipit-source-id: 914eecec769964686342d66c96d6ba76f12e1277
  • Loading branch information
Wei-Ning Hsu authored and lzzk committed Jul 24, 2022
1 parent 0e0fa88 commit 3989b86
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fairseq_cli/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
from fairseq.data import data_utils, iterators
from fairseq.data.plasma_utils import PlasmaStore
from fairseq.dataclass.configs import FairseqConfig
from fairseq.dataclass.initialize import add_defaults
from fairseq.dataclass.utils import convert_namespace_to_omegaconf
from fairseq.distributed import fsdp_enable_wrap, fsdp_wrap
from fairseq.distributed import utils as distributed_utils
Expand All @@ -45,6 +46,7 @@ def main(cfg: FairseqConfig) -> None:
cfg = convert_namespace_to_omegaconf(cfg)

utils.import_user_module(cfg.common)
add_defaults(cfg)

if (
distributed_utils.is_master(cfg.distributed_training)
Expand Down

0 comments on commit 3989b86

Please sign in to comment.