Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix anchor mistake #14

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix anchor mistake #14

merged 1 commit into from
Jul 26, 2023

Conversation

h-bo
Copy link
Contributor

@h-bo h-bo commented Jul 25, 2023

[w, h] is mis-written to [h, w]
which makes anchors error

(range of grid_y is [0, h-1], range of grid_x is [0, w-1])

[w, h] is mis-written to [h, w]
which makes anchors error
@lyuwenyu
Copy link
Owner

  1. 在同样长方形输入下,改完之后指标怎么样 比之前好了嘛
  2. 另外确认下目前后处理type是pad嘛

@h-bo
Copy link
Contributor Author

h-bo commented Jul 25, 2023

  1. 在同样长方形输入下,改完之后指标怎么样 比之前好了嘛
  2. 另外确认下目前后处理type是pad嘛
  1. 从刚开始的实验结果看,是明显好的,且好于正方形输入(800960 > 960960 > 800*800),完整的实验需要2天
    (在我们的数据上,coco没有机器跑,你有空可以跑下\笑哭)
  2. 对的

@lyuwenyu
Copy link
Owner

  1. 在同样长方形输入下,改完之后指标怎么样 比之前好了嘛
  2. 另外确认下目前后处理type是pad嘛
  1. 从刚开始的实验结果看,是明显好的,且好于正方形输入(800_960 > 960_960 > 800*800),完整的实验需要2天
    (在我们的数据上,coco没有机器跑,你有空可以跑下\笑哭)
  2. 对的

再确认一个事情 这块给的是eval_size是按照h w给的嘛 https://github.com/lyuwenyu/RT-DETR/blob/main/rtdetr_paddle/configs/rtdetr/_base_/rtdetr_r50vd.yml#L10

@h-bo
Copy link
Contributor Author

h-bo commented Jul 25, 2023

  1. 在同样长方形输入下,改完之后指标怎么样 比之前好了嘛
  2. 另外确认下目前后处理type是pad嘛
  1. 从刚开始的实验结果看,是明显好的,且好于正方形输入(800_960 > 960_960 > 800*800),完整的实验需要2天
    (在我们的数据上,coco没有机器跑,你有空可以跑下\笑哭)
  2. 对的

再确认一个事情 这块给的是eval_size是按照h w给的嘛 https://github.com/lyuwenyu/RT-DETR/blob/main/rtdetr_paddle/configs/rtdetr/_base_/rtdetr_r50vd.yml#L10

对的 就像这个配置 #13 (comment)

@lyuwenyu lyuwenyu merged commit 8ec57b6 into lyuwenyu:main Jul 26, 2023
@Ryanshuai
Copy link

Ryanshuai commented Jun 24, 2024

感谢踩坑,还是想确认一下,麻烦下作者 @lyuwenyu , Pytorch那边有类似的问题吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants