Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation to show more config options #24

Merged
merged 1 commit into from
Sep 2, 2014

Conversation

mcwebb
Copy link
Contributor

@mcwebb mcwebb commented Sep 2, 2014

accountUpdatePath wasn't mentioned in the documentation, but is quite important for anyone connecting to a non Devise api. While it's easy enough to find in the source I've added it and accountDeletePath to the doc for completeness.
There are a two more config options which aren't mentioned in the doc (namely validateOnPageLoad and forceHardRedirect), but I haven't added them here in case there is a reason they're left out of the doc.

@lynndylanhurley
Copy link
Owner

Thanks @mcwebb! I just finished work on these features. I'll merge this PR once the features are running on the demo site.

lynndylanhurley added a commit that referenced this pull request Sep 2, 2014
Updated documentation to show more config options
@lynndylanhurley lynndylanhurley merged commit d7adb55 into lynndylanhurley:master Sep 2, 2014
@lynndylanhurley
Copy link
Owner

@mcwebb - thanks for this. I didn't realize that I'd already (mistakenly) pushed the rest of the documentation for the $auth.updateAccount and $auth.destroyAccount methods! Total oversight on my part. This PR has been merged into master.

@mcwebb
Copy link
Contributor Author

mcwebb commented Sep 2, 2014

Great! Glad I could be of help.

nbrustein pushed a commit to nbrustein/ng-token-auth that referenced this pull request May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants