make sure listeners can be cleaned up #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sweet ... nice catch! |
booleanbetrayal
added a commit
that referenced
this pull request
Aug 5, 2015
make sure listeners can be cleaned up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@booleanbetrayal you were needing to call handleValidAuth again because the window close listener was not getting cleaned up, so when the window closed, it was canceling the auth it still thought was ongoing, and that was deleting auth headers.
The fix is the make sure cancelOmniauthInAppBrowserListeners is saved in this. I think this bug was introduced in translating from js back to coffeescript. That's why we saw it work before.