CommonJS package manager support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviogranero
force-pushed
the
commonjs_support
branch
from
756c18f to
4f8a9ff
Compare
|
Hi @flaviogranero - thank you for sending this PR! I'm all about merging this, but I'm having a hard time reviewing the changes because every single line is changed (I'm sure it's due to indentation). Before I go through it line by line, is there a way to make a version of this PR that shows only the changes? Thanks again! |
flaviogranero
force-pushed
the
commonjs_support
branch
from
4f8a9ff to
2001a3d
Compare
flaviogranero
force-pushed
the
commonjs_support
branch
from
2001a3d to
e61dcde
Compare
|
hi @lynndylanhurley, yes.. I was trying to put all the code inside a IIFE to make the code scope more secure, but sounds like git is not showing a good diff, so I removed this part of the change. |
|
Cool, thx @flaviogranero! If you push the IIFE as a separate PR, I'll merge that as well. |
lynndylanhurley
added a commit
that referenced
this pull request
Mar 16, 2015
CommonJS package manager support
|
And welcome new contributor 🎱 |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use ng-token-auth in a project that manages its modules using browserify. In order to be able to load this lib as a CommonJS module, we need a few changes I'm including in this pull request.
Let me know if you have any questions.