This repository has been archived by the owner on May 17, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team and I were interested in Lyft/mapper as a replacement for ObjectMapper and we needed it to work with swift3 beta 6.
This is just a proposal that makes the tests succeed, but may not be the best solution.
Some method parameters should be adjusted to fit the spirit of the 'Grand renaming' more closely.
For example this method that could be renamed to:
JSON(from field: String)
so it would readlet result = JSON(from: string)
Furthermore we need to be aware that a 'var some: Any' can now be downcast to 'AnyObject' everytime, like here.