loader: make AddUpdateCallback thread-safe and don't block signaling #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
force-pushed
the
cev/callback
branch
7 times, most recently
from
604b006 to
2eca70a
Compare
This commit makes the Loader.AddUpdateCallback() method thread-safe and ensures that signaling callbacks never blocks. Previously, if signaling a callback blocked it would deadlock the Loader.
charlievieth
force-pushed
the
cev/callback
branch
from
2eca70a to
144e8df
Compare
twoism
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the Loader.AddUpdateCallback() method thread-safe and
ensures that signaling callbacks never blocks. Previously, if signaling
a callback blocked it would deadlock the Loader.