-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify certificate #47
base: main
Are you sure you want to change the base?
Conversation
Hi! We were talking about being able to specify a certificate there: #46 (comment) I was thinking the config would point to two files instead of having to paste the certificates in the config itself. What do you say? |
We can do that also. I was trying to get the input as close to the Node.js options as I could to avoid extra processing, but storing them as files is definitely easier for the most common scenarios. I'll try to find some time tomorrow to adjust the implementation. Thanks! |
@lydell I've pushed a change for the configuration to point to a file instead of containing the certificate contents. Let me know if there's anything else you need. Thanks! |
Thanks! I’ll look into this soon. I’m going to update the docs, write tests (this repo has 100 % coverage), review error messages etc. |
Here are some rough notes I made for myself (just to show you what the status is):
I want to do that soon, but now it’s December and other things usually get in the way. |
Our standard dev setup includes using local domains with generated certificates (e.g.
https://client.local
), so being able to pass a trusted certificate through to elm-watch improves our experience quite a bit. Let me know if there are any changes you'd like to my approach here. Thanks!