Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker image #40 #52

Merged
merged 8 commits into from
Dec 2, 2020
Merged

Add Docker image #40 #52

merged 8 commits into from
Dec 2, 2020

Conversation

mre
Copy link
Member

@mre mre commented Nov 30, 2020 •
edited
Loading

Adds an initial Docker image to the repo.

TODO

  • Set up automatic deployment of the image after every push to master.

@mre mre marked this pull request as ready for review November 30, 2020 22:19
@mre mre requested a review from pawroman November 30, 2020 22:19
@mre mre mentioned this pull request Dec 1, 2020
Open
21 tasks
pawroman
pawroman reviewed Dec 1, 2020
View reviewed changes
.github/workflows/docker.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@mre
Copy link
Member Author

mre commented Dec 1, 2020

@pawroman thanks for the review. Addressed your comments. Just two more open questions. Let me know what you think and if we're good to merge. 😃

@mre
Copy link
Member Author

mre commented Dec 2, 2020

I... guess we're clear here. Merging this in.

@mre mre merged commit 936c544 into master Dec 2, 2020
@mre mre deleted the docker-image branch December 2, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawroman pawroman pawroman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mre @pawroman