Fix issues with some dependencies #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Try to make lychee buildable for Apple Silicon (ring) * Fix issues with old tokio 0.2 deps (async_smtp)
|
The publish check failed, which is to be expected as mentioned above. |
|
Thanks for this; Homebrew only packages stable releases though, so the PR at Homebrew will have to wait for the upstream dependencies. I appreciate you taking the time to troubleshoot and wander down this rabbit hole though. |
|
That was sort of my suspicion. Fingers crossed that this will happen soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles the homebrew package issues (#59) and #131.
We won't be able to release a new crate because we're using git dependencies, but at least
mastershould be stable for now and the lychee-action should get unblocked.