Fix readability

lxsmnsyc · Oct 23, 2023 · f352a92 · f352a92
1 parent 0ee25e3
commit f352a92
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 62 deletions.
diff --git a/packages/babel/example.js b/packages/babel/example.js
@@ -22,7 +22,8 @@ let bar = $signal('bar')
 
 const example = {
   foo: $property(foo),
-  'test': $property(bar),
+  bar: $property(bar),
+  baz: baz,
 };
 
 $(console.log(example.foo, example.bar));

diff --git a/packages/babel/src/core/deref-memo.ts b/packages/babel/src/core/deref-memo.ts
@@ -31,7 +31,7 @@ export default function derefMemo(
         return;
       }
       const trueCallee = unwrapNode(p.node.callee, t.isIdentifier);
-      if (!trueCallee || p.scope.hasBinding(trueCallee.name) || !CALL_CTF.has(trueCallee.name)) {
+      if (!trueCallee || !CALL_CTF.has(trueCallee.name)) {
         return;
       }
       const rawArgs = p.node.arguments[0];

diff --git a/packages/babel/src/core/deref-signal.ts b/packages/babel/src/core/deref-signal.ts
@@ -97,7 +97,6 @@ export default function derefSignal(
         const trueCallee = unwrapNode(trueCallExpr.callee, t.isIdentifier);
         if (
           !trueCallee
-          || p.scope.hasBinding(trueCallee.name)
           || !OBJECT_PROPERTY_CTF.has(trueCallee.name)
         ) {
           return;

diff --git a/packages/babel/src/core/proto.ts b/packages/babel/src/core/proto.ts
@@ -85,11 +85,11 @@ function getNamespacedKey(
   switch (identifier.type) {
     case 'StringLiteral':
     case 'NumericLiteral':
-      return t.stringLiteral(`${ROOT_SYMBOL}${name}$${identifier.value}`);
+      return t.stringLiteral(`${ROOT_SYMBOL}${name}__${identifier.value}`);
     case 'Identifier':
-      return t.identifier(`${ROOT_SYMBOL}${name}$${identifier.name}`);
+      return t.identifier(`${ROOT_SYMBOL}${name}__${identifier.name}`);
     case 'NullLiteral':
-      return t.identifier(`${ROOT_SYMBOL}${name}$null`);
+      return t.identifier(`${ROOT_SYMBOL}${name}__null`);
     default:
       return undefined;
   }