Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale configuration when under wayland #996

Open
stefonarch opened this issue May 16, 2024 · 4 comments
Open

Add scale configuration when under wayland #996

stefonarch opened this issue May 16, 2024 · 4 comments

Comments

@stefonarch
Copy link
Member

Expected Behavior

Also scale should be configurable under kwin_wayland

Current Behavior

It's not.

Context

Different scale settings for different monitors can be useful in LXQt Kwin_wayland

@stefonarch stefonarch changed the title Add scale configuration under when underwayland Add scale configuration when under wayland May 16, 2024
@stefonarch stefonarch moved this to Todo/Issues in Wayland Support May 16, 2024
@stefonarch
Copy link
Member Author

stefonarch commented Sep 21, 2024

If monitors are scaled (using systemsettings) lxqt-config-monitor can't handle it:
b.com//issues/996, and atm only KDE can configure scaling.

Schermata_20240921_102446
Schermata_20240921_102511

In this case at next login it will apply its configuration which is

Schermata_20240921_210818

and the monitor setup will be completely broken (cursor can't exit primary monitor) until it's fixed by KDE's systemsettings (where it sees a space between monitors which is invalid).

@tsujan
Copy link
Member

tsujan commented Sep 21, 2024

Theoretically, we just need to add KScreen::Output::scale and KScreen::Output::setScale to the GUI.

@stefonarch
Copy link
Member Author

And the previews of the monitors will be fine too in their size?

@tsujan
Copy link
Member

tsujan commented Sep 21, 2024

Making previews work with scaling is only one part of the job. We need to add GUI elements to set and get the scales of all monitors, depending on whether we're on Wayland or not. We also need to save the new settings in a backward compatible way.

And these steps are just what came to my mind without writing a single line of code — sometimes there's a long way from theory to practice ;) But it's good to know that there is a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo/Issues
Development

No branches or pull requests

2 participants