Update wincmd.c

[kurokawachan]

Fixing issue

#77

[ib]

Please note that

• you could add the GDK_BUTTON_PRESS check to if (event->button == 1).
• you still get two GDK_BUTTON_PRESS events.

In your commit, you should briefly explain what you changed and why. This will make it easier to understand later.

[kurokawachan]

Thanks,

you could add the GDK_BUTTON_PRESS check to if (event->button == 1).

Yes, it make sense

you still get two GDK_BUTTON_PRESS events

Yes, and it is the right behavior.
What we are trying to avoid is this function being trigger by GDK_2BUTTON_PRESS events.

If we click the toggle too fast, an GDK_2BUTTON_PRESS would be triggered.
If we click the toggle Not fast, no GDK_2BUTTON_PRESS would be triggered.

You could take a look at here

I believe this toggle should only toggle on and off, double click does not make sense.

I would draft another pull request.

[kurokawachan]

Hello @ib I just updated the GDK_BUTTON_PRESS check as you requested.

[ib]

I was thinking of something more straightforward and easier to understand.

You gave the description in your issue and pull request comments, but that should go in the commit message.

I have edited your patch. If you agree with it, I'll apply it.

[kurokawachan]

Hello, please do. Thanks

[ib]

Thank you very much for your contribution.