Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for io.bus and io.cache for shared filesystems with VMs #951

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Add support for io.bus and io.cache for shared filesystems with VMs #951

merged 7 commits into from
Jun 27, 2024

Conversation

SpiffyEight77
Copy link
Contributor

Description

@stgraber
Copy link
Member

Reviewing this one now.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jun 27, 2024
@stgraber
Copy link
Member

Summary of the changes I made to this:

  • Added the API extension commit
  • Separated the validation change into its own commit
  • Added more specific startup time validation to that commit
  • Re-worked the code a tiny bit to reduce the diff by moving the condition into the function
  • Split the io.cache from io.bus commit
  • Added a commit for the generated config metadata

@stgraber stgraber changed the title feat: add support for io.bus and io.cache for shared filesystems with VMs Add support for io.bus and io.cache for shared filesystems with VMs Jun 27, 2024
@stgraber
api: disk_io_bus_cache_filesystem
651e5e7 
Closes lxc#599

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
SpiffyEight77 and others added 4 commits June 26, 2024 22:39
@SpiffyEight77 @stgraber
incusd/device/disk: Extend io.bus option
417d94b 
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
@stgraber
incusd/device/disk: Extend io.cache option
4e89133 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@SpiffyEight77 @stgraber
incusd/device/disk: Add support for io.cache on virtiofs
b4e888c 
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
@SpiffyEight77 @stgraber
incusd/device/disk: Add support for io.bus on filesystems
911e5a3 
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
@stgraber
incusd/instance/driver_qemu: Handle 9p being disabled
b378d59 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
doc: Update configs
0dab18a 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
Copy link
Member

Did some tests and had to fix:

  • Missing validation on io.cache for the new metadata value
  • Missing handling of disk without 9p in the QEMU driver

@stgraber stgraber merged commit 48bf032 into lxc:main Jun 27, 2024
28 of 30 checks passed
@SpiffyEight77 SpiffyEight77 deleted the feat/shared-filesystems branch June 29, 2024 12:19
@SpiffyEight77
Copy link
Contributor Author

Thank you so much; I learned a lot from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpiffyEight77 @stgraber