Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance start timestamp (uptime) #829

Merged
merged 7 commits into from
May 4, 2024

Conversation

BajuMcBites
Copy link
Contributor

@BajuMcBites BajuMcBites commented May 3, 2024

Issue #729

  • implemented common.StartedAt
  • added StartedAt to InstanceState
  • called StartedAt on api calls to 1.0/instances/{name}/state

@github-actions github-actions bot added the API Changes to the REST API label May 3, 2024
@stgraber
Copy link
Member

stgraber commented May 4, 2024

Sorted this one out:

  • Added the missing API extension commit
  • Added reference to the API extension to the shared/api commit
  • Generated the swagger API commit
  • Added error handling to the driver_lxc implementation
  • Renamed the function to processStartedAt as we don't need it public
  • Ran make static-analysis and fixed what it reported

I also added a bit of extra logic to the client to show the new fields in both incus info and incus list

@stgraber stgraber marked this pull request as ready for review May 4, 2024 01:19
@stgraber stgraber self-requested a review as a code owner May 4, 2024 01:19
@github-actions github-actions bot added the Documentation Documentation needs updating label May 4, 2024
@stgraber stgraber changed the title api: Add instance uptime value Add instance start timestamp (uptime) May 4, 2024
stgraber and others added 7 commits May 3, 2024 21:36
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Sahaj Bhakta <sahajbhakta@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Closes lxc#729

Signed-off-by: Sahaj Bhakta <sahajbhakta@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber stgraber merged commit 974df22 into lxc:main May 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Development

Successfully merging this pull request may close these issues.

2 participants