-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incusd/network/ovn/nb: Port DeleteLogicalRouter and LogicalRouterSNAT (WIP) #809
Conversation
Signed-off-by: Abhiram824 <abhisuhaas1@gmail.com>
b23bfb4
to
f3a6c1b
Compare
Did a few changes:
|
The NAT logic looks wrong. The way things are stored in OVN is that each NAT rule belongs in the NAT table (ovnNB.NAT) and is referenced by its UUID from the LogicalRouter table. The logic you've added seems to assume that the external IP is directly part of the NAT field. I'll take a quick stab at rewriting the logic. Basically I expect we need to:
|
Confirmed our test suite caught the bad logic, so at least I can use that to confirm my implementation works :)
|
Signed-off-by: Abhiram824 <abhisuhaas1@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
f3a6c1b
to
8f0f388
Compare
Updated the SNAT function to do what I described above. I've got the testsuite running now to make sure it didn't regress anything. |
I see this makes sense, apologies for the confusion. Assuming this works I will go ahead and update the NAT related functions using a similar logic |
Hi, we made a few more changes to the CreateLogicalRouterNAT with additional arguments to determine whether it is SNAT or DNAT, and then create the record accordingly. I also deleted the LogicalRouterDNATAdd function. |
No description provided.