incusd/network/ovn: rewrote LogicalRouterAdd to use o.client #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New function looks good, so now you need a commit to remove the old |
|
Hi, I've updated the LogicalRouterAdd usage with CreateLogicalRouter accordingly. |
Signed-off-by: Dhruv Nistala <68369981+DhruvNistala@users.noreply.github.com>
Signed-off-by: dhruvvnistala <dhruv.nistala@utexas.edu>
stgraber
force-pushed
the
libovsdb_integration
branch
from
67f1654
to
06c4111
Compare
|
I've done a quick rebase on this one to get rid of the merge commits, I also added the missing description comment on the new function and ran |
Signed-off-by: dhruvvnistala <dhruv.nistala@utexas.edu>
stgraber
force-pushed
the
libovsdb_integration
branch
from
06c4111
to
ec288a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.