Use /1.0/events when under OpenFGA #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see if the tests catch anything I didn't consider... |
|
Ah right, I tested project-wide permissions, object-specific ones are the problem, will look into that soon. |
…ccessible If we're not allowed to get a project-wide event stream, fallback to the operations wait API. This is to accomodate the rare situation where a user is given access to specific instances within a project but without any other project-wide permissions. Closes lxc#292 Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I expected that this would need a bunch of work in the event handler and operation handler, but after doing a bit of poking, it looks like we've actually added all the needed filtering already and one can actually call
/1.0/events?all-projects=truetoday and only get the events that they should be getting (no logging, only operation and lifecycle for projects that they have access to).I've done a bunch of testing both from the CLI and UI and can indeed only see the expected events.
Closes #292