Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incusd/instance/qemu: Fix handling of > 64 limits.cpu #640

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

stgraber
Copy link
Member

Sponsored-by: ActivePort (https://www.activeport.com.au)

@stgraber
Copy link
Member Author

For whoever reviews this, we were getting the issue because on x86_64, CPUs are always hotplugged unless a specific pin is in place. So in the > 64 case without hotplug on x86_64, the cpuCount was set to 1 which would lead to an upper limit of 64 and therefore be immediately hit when hot plugging the remaining CPUs.

With the update, the hotplug case can now expose a separate cpuRequested with the eventual CPU count, this then sets the max to match that and allows things to behave while still not raising the max above 64 except for those cases.

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: ActivePort (https://www.activeport.com.au)
@hallyn hallyn merged commit 6d85cb2 into lxc:main Mar 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants