Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serial number option for type usb, and make busnum and devnum available as config keys for device type usb. #629

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Add serial number option for type usb, and make busnum and devnum available as config keys for device type usb. #629

merged 6 commits into from
Mar 21, 2024

Conversation

MHaukelid
Copy link
Contributor

@MHaukelid MHaukelid commented Mar 18, 2024 •
edited by stgraber
Loading

Closes #593
Closes #594

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Mar 18, 2024
@stgraber
Copy link
Member

Taking a look at this, will handle the rebase, tests, ... from this point on and possibly incorporate the changes from @monstermunchkin too (#628)

@stgraber
Copy link
Member

I did a few small changes:

  • Re-titled some commits
  • Split out the resources API changes
  • Undid an API breakage (int => uint32)
  • Simplified some of the comparison logic (since we're using integers even though kernel type is uint32)
  • Re-generated the swagger model

Just waiting for all tests to pass and then we can merge that one.

@stgraber stgraber mentioned this pull request Mar 21, 2024
Closed
MHaukelid and others added 6 commits March 21, 2024 16:37
@MHaukelid @stgraber
api: device_usb_serial
635747f 
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
@MHaukelid @stgraber
doc: Add busnum, devnum and serial to USB devices
bb60571 
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
@MHaukelid @stgraber
shared/api: Add Serial to ResourcesUSBDevice
060dfca 
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
@MHaukelid @stgraber
incusd/resources: Add USB Serial
e6bb09e 
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
@MHaukelid @stgraber
incusd/devices/usb: Add serial, busnum and devnum options
7625b28 
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
@stgraber
doc/rest-api: Refresh swagger YAML
2b210b2 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber stgraber merged commit 75ee076 into lxc:main Mar 21, 2024
25 checks passed
@jeff-hillman jeff-hillman mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Milestone
No milestone
2 participants
@MHaukelid @stgraber