-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and document support for encrypted keys #468
Conversation
|
9756265
to
61fe4f5
Compare
@stgraber I'm missing something obvious with
This didn't match the output of github actions? I can run the actions in my own personal fork but that's obviously not ideal: https://github.com/PriceChild/incus/actions/runs/7803489771/job/21283375479 |
1788e5f
to
0f987b2
Compare
Fixed those, it's the usual issue with capitalization of Incus and having a bunch of other stuff be escaped.
I've added a commit which adds a section for this now.
Yeah, that may need tweaking. You can work around it through the
I've added support for SSH's encrypted key format, currently limited to ECDSA and update the documentation to recommend that for the EC case. |
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
I've expanded support to also cover RSA keys through SSH encryption and so updated the instructions to always use ssh-keygen. |
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Joseph Price <joe@pricey.uk>
Thank you for sorting that all out. I'm still not sure why the linting tools gave different results locally. Looking.. |
Gives hints and limitations on encrypting the client key.